Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2910

Merged
merged 13 commits into from
Sep 24, 2024
Merged

[Release] Stage to Main #2910

merged 13 commits into from
Sep 24, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Sep 19, 2024 •
edited by mokimo
Loading

Zero impact:

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

Deva309 and others added 2 commits September 19, 2024 00:48
@Deva309
[MWPW-157924] - Added functionality to disable Active Element Detecti…
e3844f2 
…on (#2892)

Added functionality to disable Active Element Detection
@3ch023
MWPW-158464: Switch Odin endpoint (#2894)
c80cf18 
* init plans cards doc

* switch to QA bucket

* add plans html

* add test payload

* upd path

* card

* test hlxignore

* test

* remove test files

* remove edge payload

* add marquee

* add spacing
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 19, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
libs/deps/mas/mas.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
libs/deps/mas/merch-datasource.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
libs/features/mas/mocks/aem.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
libs/features/mas/web-components/src/merch-datasource.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
libs/features/mas/web-components/test/merch-datasource.test.html.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (54c3cc0) to head (b600045).
Report is 65 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
+ Coverage   96.24%   96.27%   +0.03%     
==========================================
  Files         236      239       +3     
  Lines       54233    54669     +436     
==========================================
+ Hits        52196    52634     +438     
+ Misses       2037     2035       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgclayton
MWPW-154059 - Milo templates library (#2855)
549c71f 
* MWPW-154059 - Milo templates library

* Allows template-metadata block to output metadata block in template
* Fixes inital listing order
* Adds search ability to templates

Resolves: MWPW-154059

* Updating unit tests

* Addressing eslint issue

* Address PR feedback

---------

Co-authored-by: Ryan Clayton <[email protected]>
@mokimo mokimo mentioned this pull request Sep 19, 2024
Merged
@robert-bogos @overmyheadandbody
[MWPW-158756] Enhance stage links conversion for cross-domain localiz…
740348c 
…ation (#2913)

* support cross-domain localization on stage links conversion

* Update libs/utils/utils.js

Co-authored-by: Rares Munteanu <[email protected]>

* hotfix

---------

Co-authored-by: Rares Munteanu <[email protected]>
@github-actions @actions-user
[AUTOMATED-PR] Update imslib.min.js dependency (#2872)
647f799 
Update self hosted dependency

Co-authored-by: GitHub Action <[email protected]>
@aem-code-sync aem-code-sync bot temporarily deployed to stage September 23, 2024 16:16 Inactive
github-actions[bot]
github-actions bot reviewed Sep 23, 2024
View reviewed changes
.github/workflows/label-zero-impact.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

@tedAir tedAir self-requested a review September 23, 2024 22:48
@skumar09
[MWPW-158872 : NALA] Update Nala GitHub Action runs to correctly hand…
b600045 
…le bot-generated PR details. (#2930)

* update the globalset for nala run

* fix eslint errors

* remove comma from console message

* fix eslint comma-dangle rule

---------

Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
@milo-pr-merge milo-pr-merge bot merged commit 7c2d611 into main Sep 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Dli3 Dli3 Dli3 approved these changes

@tedAir tedAir tedAir approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

@bandana147 bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

@Sartxi Sartxi Awaiting requested review from Sartxi Sartxi is a code owner

@ryanmparrish ryanmparrish Awaiting requested review from ryanmparrish ryanmparrish is a code owner

@auniverseaway auniverseaway Awaiting requested review from auniverseaway auniverseaway is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala-on-caas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.